Prevent silencing ExitFailure in ProcessContext->join() #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was an ExitSuccess, it's expected to be 0. If no failure was present, then the exit code is the only thing to be reported. But, if there was an ExitFailure, and the process did not cleanly exit, the failure most likely was the cause of the unclean exit and should be reported in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was an ExitSuccess, it's expected to be 0. If no failure was present, then the exit code is the only thing to be reported.
But, if there was an ExitFailure, and the process did not cleanly exit, the failure most likely was the cause of the unclean exit and should be reported in any case.
I'm not sure whether returning or throwing is the best course of action, but possibly we should throw the failure after .. the join() call.