Avoid PHP object allocation issue

trowski · trowski · commit a922ec764d58 · 2025-02-08T09:02:53.000-06:00
PooledWorker::__destruct() is run even if $this-&gt;selectWorker() never returns because the object is allocated prior to the constructor call.
diff --git a/src/Worker/ContextWorkerPool.php b/src/Worker/ContextWorkerPool.php
@@ -213,7 +213,8 @@ private static function killWorkers(
 
     public function getWorker(): Worker
     {
-        return new Internal\PooledWorker($this->pull(), $this->push);
+        $worker = $this->pull();
+        return new Internal\PooledWorker($worker, $this->push);
     }
 
     /**
diff --git a/src/Worker/DelegatingWorkerPool.php b/src/Worker/DelegatingWorkerPool.php
@@ -118,7 +118,8 @@ private function clearWaiting(\Throwable $exception): void
 
     public function getWorker(): Worker
     {
-        return new PooledWorker($this->selectWorker(), $this->push(...));
+        $worker = $this->selectWorker();
+        return new PooledWorker($worker, $this->push(...));
     }
 
     public function getWorkerLimit(): int

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,8 @@ private static function killWorkers(`
`213`	`213`
`214`	`214`	`public function getWorker(): Worker`
`215`	`215`	`{`
`216`		`- return new Internal\PooledWorker($this->pull(), $this->push);`
	`216`	`+ $worker = $this->pull();`
	`217`	`+ return new Internal\PooledWorker($worker, $this->push);`
`217`	`218`	`}`
`218`	`219`
`219`	`220`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,8 @@ private function clearWaiting(\Throwable $exception): void`
`118`	`118`
`119`	`119`	`public function getWorker(): Worker`
`120`	`120`	`{`
`121`		`- return new PooledWorker($this->selectWorker(), $this->push(...));`
	`121`	`+ $worker = $this->selectWorker();`
	`122`	`+ return new PooledWorker($worker, $this->push(...));`
`122`	`123`	`}`
`123`	`124`
`124`	`125`	`public function getWorkerLimit(): int`