Merged
Conversation
Owner
|
You might need to suppress the linting on the line that failed, since the glob signature is different over the different python versions |
2aca0fc to
2e60b90
Compare
Fixes amoffat#708 glob.glob has many possible arguments but the current wrapping solution doesn't cover all them. This change directly passes all args (positional and kw) as-is to the wrapped function.
amoffat
approved these changes
Nov 20, 2023
Owner
|
Thanks for the contribution @Pistahh 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
glob.glob has many possible arguments but the current wrapping solution doesn't cover all them.
This change directly passes all args (positional and kw) as-is to the wrapped function.