Skip to content

Glazewm Workspaces - Add Optional Distinction Between Active and Focused Workspaces #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amnweb merged 2 commits into from
Nov 14, 2025
Merged

Glazewm Workspaces - Add Optional Distinction Between Active and Focused Workspaces #550

amnweb merged 2 commits into from
Nov 14, 2025

Conversation

@EmilBerbakov
Copy link
Contributor

@EmilBerbakov EmilBerbakov commented Nov 10, 2025 •
edited
Loading

Implements the request asked for here (Widget)-GlazeWM-Workspaces - Add an Optional Distinction Between an Active Workspace and a Focused Workspace.

This PR adds the following:

Widget Code

  • added two new statuses: FOCUSED_EMPTY and FOCUSED_POPULATED
  • added a refresh_widget_style call for the text_label of GlazewmWorkspaceButtonWithIcons
    • this allows the ability to add targeted, status-specific styling to the .label class of the button when app icons are enabled

yaml options:

  • focused_populated_label and focused_empty_label
    • These function like their active counterparts. If not set, they will take on the values of their active counterparts to maintain current functionality
  • enabled_focused
    • This enables app icons for focused workspaces. It is nullable, and if not set, takes on the value of active_focused to maintain current functionality

CSS customization:

  • focused_populated and focused_empty
    • Whenever a workspace is determined to be FOCUSED_POPULATED or FOCUSED_EMPTY, both the relevant active class is applied, followed by the relevant focused class. This allows for CSS customization for focused statuses to be entirely optional, and all previous stylings will be unaffected.
      • This also means that, in order to opt in, one must define the focused styles after their respective active stylings. This quirk has been added to the documentation

Video-Nomad
Video-Nomad approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@Video-Nomad Video-Nomad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The code looks good to me, and I can't find any issues with the styling or backwards compatibility. Without changing anything my old config looks the same and the new stuff works too if I add it 👍

Just a small note (for myself mostly not related to this PR): there is a small styling bug with icons enabled and empty (not active) workspaces not having the correct style from .glazewm-workspaces .ws-btn.empty. In GlazeWM workspaces should be set to keep_alive: true. If you want to check this out and fix it in this PR that would be great but it's fine to leave that, I can fix it later.

Another note on commit history - please clean it up a bit. It's fine to have multiple commits in a PR but please check other commits and how they are written and styled. Maybe rebase and squash some of them if they are redundant.

@EmilBerbakov EmilBerbakov force-pushed the feature/glazewm-workspaces-distinguish-between-active-and-focused branch from 5764fe4 to 6301c3f Compare November 10, 2025 23:07
@EmilBerbakov
feat(GlazeWM Workspaces): Add optional customization for focused work…
0d0bd82 
…space

Change _update_status for so that status logic switching does not catch on cases where they should evaluate to EMPTY and instead eval to FOCUSED_EMPTY
Add focused states to _animate_buttons
@EmilBerbakov
fix(GlazeWM Workspaces): Make sure labels for icon buttons can have t…
8b45c76 
…heir stylings updated when status changes
@EmilBerbakov EmilBerbakov force-pushed the feature/glazewm-workspaces-distinguish-between-active-and-focused branch from 6301c3f to 8b45c76 Compare November 10, 2025 23:27
@EmilBerbakov
Copy link
Contributor Author

EmilBerbakov commented Nov 11, 2025

I have updated the commit history to be a lot cleaner.

For the empty styling, are you saying that a note needs to be added to the documentation on how a workspace needs to have keep_alive set to true if they want the empty styling to be applied to said workspace, or are you saying there's a way to dynamically set that property for a workspace through a command?

@Video-Nomad
Copy link
Contributor

Video-Nomad commented Nov 11, 2025 •
edited
Loading

Sorry, nevemind, it was my mistake with the styling. Just re-tested it again and it works as expected. .glazewm-workspaces .ws-btn.empty should be .glazewm-workspaces .ws-btn.empty .label for when the icons are enabled. Forgot this detail.

So, this PR is good to go then, at least on my end. I can't merge stuff so it's up to @amnweb.

@amnweb amnweb merged commit ab13570 into amnweb:main Nov 14, 2025
5 of 6 checks passed
@EmilBerbakov EmilBerbakov deleted the feature/glazewm-workspaces-distinguish-between-active-and-focused branch November 14, 2025 18:51
@EmilBerbakov EmilBerbakov mentioned this pull request Nov 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Video-Nomad Video-Nomad Video-Nomad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmilBerbakov @Video-Nomad @amnweb