feat(scrolling_label): add always_scroll option #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added always_scroll option to Media widget - Left and Right scrolling styles will now optionally not scroll if the text fits the widget. - Set always_scroll to False by default - Set label_padding to 0 by default - Refactored ScrollingLabel class to be more stable (less text jumping)
3379623 to
f5c9836
Compare
f5c9836 to
7beefb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509
always_scrolloption to Media widget (default to False).leftandrightscrolling styles will now optionally not scroll if the text fits the widget.label_paddingto 0 by default (old value of1can be confusing for styling).ScrollingLabelclass to be more stable (less text jumping) and in general cleaner.