Skip to content

Commit d7f7dc4

Browse files
committed
fix: code smells
1 parent 03c2424 commit d7f7dc4

24 files changed

Lines changed: 54 additions & 58 deletions

resources/js/components/cards/pulse/PulseCache.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const config = computed(() => {
4444
:cols="cols"
4545
name="Cache"
4646
:title="`Time: ${format_number(pulseData.slow_outgoing_requests?.time ?? 0)}ms; Run at: ${pulseData.slow_outgoing_requests?.runAt ? new Date(pulseData.slow_outgoing_requests?.runAt).toLocaleDateString() : ''};`"
47-
:details="`past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
47+
:details="`past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
4848
>
4949
<template #icon>
5050
<IconRocketLaunch />

resources/js/components/cards/pulse/PulseExceptions.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const exceptions = computed(() => {
5353
5454
return [...list]
5555
.map((val) => {
56-
return { ...val, count: parseFloat(val.count) };
56+
return { ...val, count: Number.parseFloat(val.count) };
5757
})
5858
.sort(sortObject(sortKey, sortKey === 'count' ? -1 : 1, ['latest']));
5959
});
@@ -64,7 +64,7 @@ const exceptions = computed(() => {
6464
:cols="cols"
6565
name="Exceptions"
6666
:title="`Time: ${format_number(pulseData?.exceptions?.time ?? 0)}ms; Run at: ${pulseData?.exceptions?.runAt ? new Date(pulseData?.exceptions?.runAt).toLocaleDateString() : ''};`"
67-
:details="`past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
67+
:details="`past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
6868
>
6969
<template #icon>
7070
<IconBugAnt />

resources/js/components/cards/pulse/PulseQueues.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ function scale(data: { [key: string]: any }) {
3838
:rows="rows"
3939
name="Queues"
4040
:title="`Time: ${format_number(pulseData?.queues?.time ?? 0)}ms; Run at: ${pulseData?.queues?.runAt ? new Date(pulseData?.queues?.runAt).toLocaleDateString() : ''};`"
41-
:details="`past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
41+
:details="`past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
4242
>
4343
<template #icon>
4444
<IconQueueList />

resources/js/components/cards/pulse/PulseRequests.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function scale(data: { [key: string]: any }) {
4343
:rows="rows"
4444
name="Requests"
4545
:title="`Time: ${format_number(pulseData?.requests?.time ?? 0)}ms; Run at: ${pulseData?.requests?.runAt ? new Date(pulseData?.requests?.runAt).toLocaleDateString() : ''};`"
46-
:details="`past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
46+
:details="`past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
4747
>
4848
<template #icon>
4949
<IconArrowsLeftRight />

resources/js/components/cards/pulse/PulseSlowJobs.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const config = computed(() => {
6363
:cols="cols"
6464
name="Slow Jobs"
6565
:title="`Time: ${format_number(pulseData.slow_jobs.time ?? 0)}ms; Run at: ${pulseData.slow_jobs.runAt ? new Date(pulseData.slow_jobs.runAt).toLocaleDateString() : ''};`"
66-
:details="`${config.threshold ?? 1000}ms threshold, past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
66+
:details="`${config.threshold ?? 1000}ms threshold, past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
6767
>
6868
<template #icon>
6969
<IconCommandLine />

resources/js/components/cards/pulse/PulseSlowOutgoingRequests.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ function getDomainFromUrl(input: string): string | null {
7373
:cols="cols"
7474
name="Slow Outgoing Requests"
7575
:title="`Time: ${format_number(pulseData.slow_outgoing_requests?.time ?? 0)}ms; Run at: ${pulseData.slow_outgoing_requests?.runAt ? new Date(pulseData.slow_outgoing_requests?.runAt).toLocaleDateString() : ''};`"
76-
:details="`${config?.threshold ?? 1000}ms threshold, past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
76+
:details="`${config?.threshold ?? 1000}ms threshold, past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
7777
>
7878
<template #icon>
7979
<IconCloudArrowUp />

resources/js/components/cards/pulse/PulseSlowQueries.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const config = computed(() => {
6363
:cols="cols"
6464
name="Slow Queries"
6565
:title="`Time: ${format_number(pulseData.slow_queries.time ?? 0)}ms; Run at: ${pulseData.slow_queries.runAt ? new Date(pulseData.slow_queries.runAt).toLocaleDateString() : ''};`"
66-
:details="`${config.threshold ?? 1000}ms threshold, past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
66+
:details="`${config.threshold ?? 1000}ms threshold, past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
6767
>
6868
<template #icon>
6969
<IconCircleStack />

resources/js/components/cards/pulse/PulseSlowRequests.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const config = computed(() => {
6464
:cols="cols"
6565
name="Slow Requests"
6666
:title="`Time: ${format_number(pulseData.slow_requests?.time ?? 0)}ms; Run at: ${pulseData.slow_requests?.runAt ? new Date(pulseData.slow_requests?.runAt).toLocaleDateString() : ''};`"
67-
:details="`${pulseData.slow_requests.config?.threshold ?? 1000}ms threshold, past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
67+
:details="`${pulseData.slow_requests.config?.threshold ?? 1000}ms threshold, past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
6868
>
6969
<template #icon>
7070
<IconArrowsLeftRight />

resources/js/components/cards/pulse/PulseUsage.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const sampleRate = () => {
7676
:class="`col-span-2 lg:col-span-4`"
7777
:name="`${'Application Usage'}`"
7878
:title="`Time: ${format_number(pulseData?.queues?.time ?? 0)}ms; Run at: ${pulseData?.servers?.runAt ? new Date(pulseData?.servers?.runAt).toLocaleDateString() : ''};`"
79-
:details="`past ${validPeriods.indexOf(period) !== -1 ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
79+
:details="`past ${validPeriods.includes(period) ? periodForHumans(period) : periodForHumans(validPeriods[0])}`"
8080
>
8181
<template #icon>
8282
<IconArrowTrendingUp v-if="type.value === 'requests'" />

resources/js/components/cedar-ui/date-picker/DatePicker.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { nextTick, useTemplateRef, watch } from 'vue';
44
import { ButtonIcon, ButtonText } from '../button';
55
import { OnClickOutside } from '@vueuse/components';
66
import { UseFocusTrap } from '@vueuse/integrations/useFocusTrap/component';
7-
import { cn } from '@aminnausin/cedar-ui';
87
98
import { ButtonDatePicker, useDatePicker } from '.';
109
import { InputShell } from '../input';

0 commit comments

Comments
 (0)