fix: lyrics editor cannot reset all fields

aminnausin · aminnausin · commit d61735336bb4 · 2026-01-01T20:04:53.000-05:00
diff --git a/app/Http/Controllers/Api/V1/MetadataController.php b/app/Http/Controllers/Api/V1/MetadataController.php
@@ -76,8 +76,7 @@ public function updateLyrics(LyricsUpdateRequest $request, Metadata $metadata) {
                 throw new ModelNotFoundException('Song does not exist');
             }
 
-            unset($validated['track']);
-
+            $validated['title'] = $validated['track']; // Track is unused
             $validated['editor_id'] = Auth::id();
             $metadata->update($validated);
 
diff --git a/app/Http/Requests/LyricsUpdateRequest.php b/app/Http/Requests/LyricsUpdateRequest.php
@@ -20,7 +20,7 @@ public function authorize(): bool {
      */
     public function rules(): array {
         return [
-            'track' => 'required|max:255',
+            'track' => 'required|max:255|min:1',
             'artist' => 'nullable|max:255',
             'album' => 'nullable|max:255',
             'lyrics' => 'nullable',
diff --git a/resources/js/components/forms/EditLyrics.vue b/resources/js/components/forms/EditLyrics.vue
@@ -122,6 +122,20 @@ const handleLoadLyricInfo = () => {
     form.fields.lyrics = stateLyrics.value;
 };
 
+const handleResetFields = () => {
+    form.fields = { ...form.fields, ...buildDefaultData() };
+    resetLyrics();
+};
+
+const buildDefaultData = () => {
+    return {
+        track: props.video.metadata?.title ?? props.video.title ?? '',
+        lyrics: props.video.metadata?.lyrics ?? '',
+        artist: props.video.metadata?.artist ?? '',
+        album: props.video.metadata?.album ?? '',
+    };
+};
+
 onMounted(() => {
     handleLoadLyricInfo();
 });
@@ -195,7 +209,8 @@ watch(
             >
                 Cancel
             </ButtonForm>
-            <ButtonForm @click="handleSubmit" variant="submit" :disabled="form.processing"> Submit Details </ButtonForm>
+            <ButtonForm @click="handleResetFields" variant="danger" :disabled="form.processing"> Reset </ButtonForm>
+            <ButtonForm @click="handleSubmit" variant="submit" :disabled="form.processing"> Save </ButtonForm>
         </div>
     </form>
 </template>

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ public function updateLyrics(LyricsUpdateRequest $request, Metadata $metadata) {`
`76`	`76`	`throw new ModelNotFoundException('Song does not exist');`
`77`	`77`	`}`
`78`	`78`
`79`		`- unset($validated['track']);`
`80`		`-`
	`79`	`+ $validated['title'] = $validated['track']; // Track is unused`
`81`	`80`	`$validated['editor_id'] = Auth::id();`
`82`	`81`	`$metadata->update($validated);`
`83`	`82`