chore: code smells

aminnausin · aminnausin · commit ac040b59a29e · 2026-01-20T00:00:20.000-05:00
diff --git a/app/Jobs/VerifyFolders.php b/app/Jobs/VerifyFolders.php
@@ -134,9 +134,7 @@ private function verifyFolders(TaskService $taskService) {
 
             Series::upsert($transactions, 'id', ['folder_id', 'title', 'episodes', 'thumbnail_url', 'raw_thumbnail_url', 'total_size', 'primary_media_type', 'updated_at']);
 
-            $summary = 'Updated ' . count($transactions) . ' folders from id ' . ($transactions[0]['folder_id']) . ' to ' . ($transactions[count($transactions) - 1]['folder_id']);
-
-            return $summary;
+            return $summary = 'Updated ' . count($transactions) . ' folders from id ' . ($transactions[0]['folder_id']) . ' to ' . ($transactions[count($transactions) - 1]['folder_id']);
         } catch (\Throwable $th) {
             $ids = array_column($transactions, 'id');
 
diff --git a/resources/js/components/video/subtitles/PlayerSubtitles.vue b/resources/js/components/video/subtitles/PlayerSubtitles.vue
@@ -81,7 +81,10 @@ const defaultSubtitleTrack = computed<SubtitleResource | undefined>(() => {
 
 const handleSizeChange = (_: Event, dir: number = 0) => {
     if (dir) {
-        subtitleSizeMultiplier.value = round(Math.max(Math.min(parseFloat(`${subtitleSizeMultiplier.value}`) + subtitleSizeDelta * dir, subtitleSizeMax), subtitleSizeMin), 2);
+        subtitleSizeMultiplier.value = round(
+            Math.max(Math.min(Number.parseFloat(`${subtitleSizeMultiplier.value}`) + subtitleSizeDelta * dir, subtitleSizeMax), subtitleSizeMin),
+            2,
+        );
     }
 };
 
diff --git a/resources/js/service/util.ts b/resources/js/service/util.ts
@@ -148,7 +148,7 @@ export function isMobileDevice(): boolean {
  * @returns {string} `${formattedSize} ${unit}`.
  */
 export function formatFileSize(size: number, space = true, divisor: number = 1024): string {
-    if (isNaN(size) || size < 0) {
+    if (Number.isNaN(size) || size < 0) {
         return 'Invalid size';
     }
 
@@ -166,7 +166,7 @@ export function formatFileSize(size: number, space = true, divisor: number = 102
 }
 
 export function formatBitrate(rate: number, space = true): string {
-    if (isNaN(rate) || rate < 0) {
+    if (Number.isNaN(rate) || rate < 0) {
         return 'Invalid rate';
     }
 

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ export function isMobileDevice(): boolean {`
`148`	`148`	* @returns {string} `${formattedSize} ${unit}`.
`149`	`149`	`*/`
`150`	`150`	`export function formatFileSize(size: number, space = true, divisor: number = 1024): string {`
`151`		`- if (isNaN(size) \|\| size < 0) {`
	`151`	`+ if (Number.isNaN(size) \|\| size < 0) {`
`152`	`152`	`return 'Invalid size';`
`153`	`153`	`}`
`154`	`154`
`@@ -166,7 +166,7 @@ export function formatFileSize(size: number, space = true, divisor: number = 102`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`export function formatBitrate(rate: number, space = true): string {`
`169`		`- if (isNaN(rate) \|\| rate < 0) {`
	`169`	`+ if (Number.isNaN(rate) \|\| rate < 0) {`
`170`	`170`	`return 'Invalid rate';`
`171`	`171`	`}`
`172`	`172`