Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
First try at CI:
|
|
Here's another CI (Linux aarch64 only) with more fixes:
|
|
Full CI:
|
|
macOS failures look like a flake, since it is failing in The Windows ones are a problem, since they are failing with "Could not find 'uncrustify' executable". Need to look into the installation on Windows here. |
This may fix the Windows problem. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Here's another try at CI, now that I've done some changes here:
|
|
The failing tests on Windows are weird. A few of them show up in the latest Windows nightlies (like https://ci.ros2.org/view/nightly/job/nightly_win_rel/2150/#showFailuresLink , https://ci.ros2.org/view/nightly/job/nightly_win_rel/2149/, and https://ci.ros2.org/view/nightly/job/nightly_win_rel/2148/#showFailuresLink), but not all of them. I just can't see how this PR would cause those additional errors, though. So I'm marking this as ready to review. @audrow can you take a look? |
audrow
left a comment
There was a problem hiding this comment.
Looks good to me. I'm also not sure what to make of the windows failures. It's also not clear to me how they relate to this change.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This updates our vendored version of uncrustify to 0.72. The most compelling reason to do this is to make it match the version that is going to ship with Ubuntu Jammy. Along with this change, we are also going to need updates to a number of downstream repositories. I'll link each of the changes we need to this pull request, and run CI on the whole lot here. I'll pull it out of draft once I have CI happy.