fix custom zsh logic for handling arrays#80
Merged
dirk-thomas merged 1 commit intomasterfrom Jul 19, 2018
Merged
Conversation
Contributor
Author
|
In addition colcon/colcon-ros#29 is necessary to chain to the |
Contributor
|
while currently not necessary for it to work shouldn't the other package_level templates also set |
mikaelarguedas
approved these changes
Jul 19, 2018
Contributor
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm, assuming that this has been tested and confirmed to fix the issue
Contributor
Author
They could for consistency but there is no logic which check for e.g. |
Contributor
|
I tested this on zsh on Linux and it fixes the issue for me 👍 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ros2/ros2#546.
Otherwise when sourcing a package-level script it doesn't perform the
ament_zsh_to_arrayfunction and therefore doesn't source package environment hooks.