Skip to content

add ament_bandit wrapper#439

Closed
florcabral wants to merge 1 commit intoament:rollingfrom
florcabral:add-ament-bandit
Closed

add ament_bandit wrapper#439
florcabral wants to merge 1 commit intoament:rollingfrom
florcabral:add-ament-bandit

Conversation

@florcabral
Copy link
Copy Markdown

@florcabral florcabral commented May 11, 2023

Contribute a new wrapper for the Bandit static analyzer.

@florcabral florcabral requested a review from mjeronimo as a code owner May 11, 2023 11:54
Signed-off-by: florcabral <florencia.a.cabral@gmail.com>
@clalancette
Copy link
Copy Markdown
Contributor

My major question with this PR is: does this need to be in the ament_lint core? That is, it would be much easier to just release this into ROS 2 as a separate package, which would:

  1. Make it easier to make changes (you wouldn't have to wait for core maintainers to have time to review things).
  2. Not subject it to the stricter rules of being in the core.
  3. Reduce the support burden on the ament_lint maintainers.

Thoughts?

@clalancette clalancette added the more-information-needed Further information is required label May 18, 2023
@tfoote
Copy link
Copy Markdown
Member

tfoote commented May 18, 2023

I think it would be good to release this as a separate package initially. That way it can be used, validated and iterated upon with at a faster rate. Once it's more mature we can consider bringing it into the default installation and into this repo too.

@clalancette
Copy link
Copy Markdown
Contributor

Given the previous comments, I'm going to close this out for now. But do please consider releasing ament_bandit as a standalone package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

more-information-needed Further information is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants