[Galactic] [ament_cmake_cppcheck] Fix file exclusion behavior (#329)#367
Merged
mjeronimo merged 1 commit intoament:galacticfrom Apr 22, 2022
Merged
Conversation
The `EXCLUDE` argument of the `ament_cppcheck` CMake function is a list, i.e. a multi-value keyword. As such, it needs to be placed out of the one-value keywords from the `cmake_parse_arguments` function call. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu> (cherry picked from commit fd2feb1) Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Contributor
Author
|
CI:
|
mjeronimo
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #329 to Galactic.
The
EXCLUDEargument of theament_cppcheckCMake function isa list, i.e. a multi-value keyword. As such, it needs to be placed
out of the one-value keywords from the
cmake_parse_argumentsfunction call.
Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu
(cherry picked from commit fd2feb1)