ignore NOLINT comments with categories that come from clang-tidy#339
Merged
ignore NOLINT comments with categories that come from clang-tidy#339
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
|
Looks like a good idea to me. Also like the idea of pushing it upstream to the tool as well. |
Contributor
Author
|
Moving this into review, I would appreciate feedback. CI:
|
Signed-off-by: William Woodall <william@osrfoundation.org>
nuclearsandwich
approved these changes
Mar 16, 2022
Contributor
nuclearsandwich
left a comment
There was a problem hiding this comment.
No objections to the implementation. It'll be great if this becomes part of our upstream fork.
|
Looks good to me as well. |
mjeronimo
approved these changes
Mar 16, 2022
Contributor
Author
|
The test failures look unrelated to me and were not present on Windows. Thanks for the reviews guys. I'll see about following up on our fork if this ends up in a future version of upstream, which seems likely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I'm still running into issues with clang-tidy and cpplint colliding when using
NOLINTcomments. This is an idea on how to handle it and I've made an upstream issue to see what they think as well: cpplint/cpplint#184@nuclearsandwich @mjeronimo FYI