remove google style from clang-tidy default settings#337
Merged
Conversation
…or default config file Signed-off-by: William Woodall <william@osrfoundation.org>
nuclearsandwich
approved these changes
Nov 2, 2021
Contributor
nuclearsandwich
left a comment
There was a problem hiding this comment.
Thanks @wjwwood!
Contributor
Author
|
Hello, nice to meet you. I have one question: Based on your explanation, it seems like configuring clang-tidy would be the better approach. Could you clarify why you prefer to use cpplint instead? Is this part of a milestone where you plan to eventually transition to clang-tidy in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes the need for default config file.
I propose this change because:
cpplint.pycovers these Google style-like checks (things like using explicit on a constructor with one argument)// NOLINT(rule)) is problematic because the name of the rules are different forcpplint.pyand clang-tidy's version of the rulescpplint.py, causing more unhelpful warningsThe simplest solution, in my opinion, is to remove this from the default settings, rely on
cpplint.pyfor these kinds of checks, and let individual users add the Google style checks to their on clang-tidy config files, if they wish to use them.@nuclearsandwich FYI