[ament_cmake_uncrustify] Add file exclude support#330
Merged
audrow merged 1 commit intoament:masterfrom Nov 19, 2021
Merged
Conversation
In the `ament_uncrustify` CMake function, the optional list argument `EXCLUDE` can now be used as an exclusion specifier. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Contributor
Author
|
CI with linter tests only (
|
audrow
approved these changes
Oct 19, 2021
Contributor
audrow
left a comment
There was a problem hiding this comment.
Looks good with green CI.
Contributor
Author
|
Thank you for the review! Running CI again with linter tests only (
|
Contributor
Author
|
The test failure in Windows CI is also seen in the the Windows nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2091/testReport/ Looks like that is being discussed in ros2/launch_ros#273 |
Contributor
|
Hey @aprotyas, I believe that I asked this elsewhere, but don't remember the answer, do you have the ability to merge this, or would you like me to? |
Contributor
Author
Contributor
|
Rerunning CI, just to see if anything has changed:
|
Contributor
|
Thanks for the PR, @aprotyas! |
87 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
ament_uncrustifyCMake function, the optional listargument
EXCLUDEcan now be used as an exclusion specifier.Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu