Skip to content

Add TIMEOUT argument to ament_cmake_clang_tidy#298

Merged
mm318 merged 1 commit intoament:masterfrom
mm318:ament_cmake_clang_tidy_timeout
Feb 17, 2021
Merged

Add TIMEOUT argument to ament_cmake_clang_tidy#298
mm318 merged 1 commit intoament:masterfrom
mm318:ament_cmake_clang_tidy_timeout

Conversation

@mm318
Copy link
Copy Markdown
Member

@mm318 mm318 commented Feb 14, 2021

Closes #286

This change adds the option to set a custom timeout duration for running ament_clang_tidy.

The default timeout is set to 300 seconds, comparable to ament_cmake_cppcheck.

Signed-off-by: Miaofei <miaofei@amazon.com>
@mm318
Copy link
Copy Markdown
Member Author

mm318 commented Feb 14, 2021

CI run with build --packages-up-to ament_cmake_clang_tidy and test --packages-select ament_cmake_clang_tidy:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mm318 mm318 requested a review from audrow February 14, 2021 18:35
Copy link
Copy Markdown
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. LGTM!

@mm318 mm318 merged commit 160b012 into ament:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ament_cmake_clang_tidy: no way to set timeout

2 participants