adding cppcheck libraries option#323
Merged
jacobperron merged 2 commits intoament:masterfrom Sep 29, 2021
Merged
Conversation
added 2 commits
September 20, 2021 16:53
Signed-off-by: William Wedler <william.wedler@resquared.com>
Signed-off-by: William Wedler <william.wedler@resquared.com>
3bdf743 to
2b8a74e
Compare
jacobperron
approved these changes
Sep 20, 2021
Contributor
|
Windows build requeued: |
Contributor
Author
|
@jacobperron What is the process for this to be merged? |
Contributor
Pinging me just like this 😄 Sorry for the delay! |
mjeronimo
pushed a commit
that referenced
this pull request
Oct 20, 2021
* adding ament_cppcheck libraries option Signed-off-by: William Wedler <william.wedler@resquared.com> * pass libraries option via CMake Signed-off-by: William Wedler <william.wedler@resquared.com> Co-authored-by: William Wedler <william.wedler@resquared.com>
mjeronimo
pushed a commit
that referenced
this pull request
Oct 22, 2021
* adding ament_cppcheck libraries option Signed-off-by: William Wedler <william.wedler@resquared.com> * pass libraries option via CMake Signed-off-by: William Wedler <william.wedler@resquared.com> Co-authored-by: William Wedler <william.wedler@resquared.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am adding a
librariesoption toament_cppcheckthat is passed tocppcheck. See the cppcheck documentation http://cppcheck.net/manual.html#library-configuration for an explanation of what this option does.Here is an example of using
ament_cppcheckwith this option fromCMakeLists.txt:This addresses the issue I raised in #321