Merged
Conversation
dirk-thomas
reviewed
Mar 10, 2020
Contributor
dirk-thomas
left a comment
There was a problem hiding this comment.
Wouldn't it be better to mark the specific file as "skipped" to not pretend it was checked when it actually wasn't?
`cppcheck` can, in some cases, construct an invalid parse tree. http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastCompletedBuild/testReport/rclcpp/cppcheck/error__internalAstError__src_rclcpp_clock_cpp_159_/ ``` - rclcpp.cppcheck error: internalAstError (src/rclcpp/clock.cpp:159) <<< failure message Syntax Error: AST broken, 'if' doesn't have two operands. >>> ``` This error sounds like a syntax error, but is in fact, not. (cppcheck doesn't seem to even find the syntax error in `if(1,1){}`) This commit causes such errors to be silently ignored, as they are not actionable. Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Dan Rose <dan@digilabs.io>
Contributor
Author
It does continue to find errors, just so long as they don't depend on that part of the AST. Adding |
Contributor
|
Thanks for details. Sounds reasonable then. |
dirk-thomas
approved these changes
Mar 10, 2020
Contributor
|
(Will merge without CI since ci.ros2.org has issues at the moment and this option is available in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppcheckcan, in some cases, construct an invalid parse tree.http://build.ros2.org/user/rotu/my-views/view/CycloneDDS/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastCompletedBuild/testReport/rclcpp/cppcheck/error__internalAstError__src_rclcpp_clock_cpp_159_/
This error sounds like a syntax error, but is in fact, not. (cppcheck doesn't seem to even find the syntax error in
if(1,1){})This commit causes such errors to be silently ignored, as they are not actionable.
Signed-off-by: Dan Rose dan@digilabs.io