-
Notifications
You must be signed in to change notification settings - Fork 127
Duplicate functions across ament linters with different functionality #157
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Many of the linters (clang-format, cppcheck, cpplint, flake8, pep257, etc.) utilize identically named functions (get_xunit_content, get_files, and find_executable) which all express a similar but slightly different functionality based on the linter being used.
Core Functionality of Identically-Named Functions
Note: Given this issue, some of the received arguments may vary between linters
get_xunit_content
- Receive a report consisting of logging data, a test name, and an elapsed time
- Log to an
.xmlfile
get_files
- Receive the paths to consider and the desired file extensions
- Return the valid files
find_executable
- Receive a file name indicating the desired executable and additional specified paths (default is None)
- Search PATH and additional paths for the executable
These functions could likely be unified and condensed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request