Merged
Conversation
27fc614 to
d04155f
Compare
292b0e5 to
93efb13
Compare
Contributor
|
LGTM. Depends on #17. |
Contributor
Author
|
thanks. I should have highlighted that this has a base branch of #17 so you can merge it into that PR if you prefer |
Contributor
|
I don't think we need to shuffle this around more then necessary. Its fine to keep it separate and rebase / merge after the other PR has been merged. |
d7b2a2d to
80b1090
Compare
93efb13 to
2832552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux, OS X, Windows