Add type annotations to python files.#93
Conversation
|
Hm. The build farm seems to be failing before even building with a rosdep error. |
We're in the middle of transition to Ubuntu 24.04, so automatic testing isn't working at the moment. We still have manual CI we can run. |
Ah that makes sense. |
|
I believe I have made all the requested changes. Let me know if you have any other comments or concerns. |
clalancette
left a comment
There was a problem hiding this comment.
This looks good, thanks for iterating.
|
CI:
|
clalancette
left a comment
There was a problem hiding this comment.
It looks like flake8 isn't happy with these changes: https://ci.ros2.org/job/ci_linux/20444/testReport/junit/ament_index_python.ament_index_python.test/test_flake8/test_flake8/
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
52aea43 to
ca5eebf
Compare
|
Let's try CI again:
|
|
Windows CI is failing, likely because of the use of the older Python 3.8. @InvincibleRMC can you take a look? |
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
|
New CI:
|
While adding type annotations to rclpy noticed some ament_index_python files were untyped.