Remove the Quality Level from the README.md.#62
Merged
clalancette merged 1 commit intomasterfrom Jul 10, 2020
Merged
Conversation
It is duplicating information from the QUALITY_DECLARATION.md. Just put a link to the QD, which should be good enough. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ahcorde
approved these changes
Jul 7, 2020
Contributor
Author
|
I'm going to go ahead and merge this one; thanks @ahcorde for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is duplicating information from the QUALITY_DECLARATION.md.
Just put a link to the QD, which should be good enough.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
We discussed this quite a bit over https://github.com/ament/ament_index/pull/61/files#r448358899 . There was actually no conclusion there, but it seems to me that duplicating information that is right alongside this is just going to lead to additional maintenance in the future. Thus, this PR de-duplicates that information. I wanted to open this so we didn't lose track of the discussion; if there is still disagreement, we can continue the discussion here.