Increase test coverage ament_index_python#41
Merged
Blast545 merged 3 commits intoament:masterfrom Jan 22, 2020
Merged
Conversation
ivanpauno
reviewed
Jan 21, 2020
Contributor
ivanpauno
left a comment
There was a problem hiding this comment.
Some extra comments, but it's looking better!
Contributor
|
What makes this PR harder to review than necessary is the mixture of unrelated changes. The patch does add tests as indicated by the title but also does some random code changes (arguably improvements) as well as refactorings to use different concepts (like I strongly suggest to keep changes separate and create different PRs for unrelated changes. That will make sure that each can be reviewed easily and can get merged quickly. |
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Contributor
Author
|
I removed code change improvements for now. |
dirk-thomas
reviewed
Jan 22, 2020
ivanpauno
approved these changes
Jan 22, 2020
Contributor
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM with Dirk's comment addressed and green CI.
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Contributor
Author
|
CI:
|
dirk-thomas
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests added to remaining functions in the package