[backport] Fix headers destination installed by ament_auto_package (#540)#574
[backport] Fix headers destination installed by ament_auto_package (#540)#574HansRobo wants to merge 1 commit intoament:humblefrom
Conversation
* fix headers destination installed by ament_auto_package Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Fix exporting include directory target by ament_auto_package Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
|
Thank you for the backports! I'm hesitant to accept this backport. While it's uncommon, I've come across people hard-coding include paths to use their non-CMake build system. This change would break those kinds of builds. |
|
That perspective was certainly overlooked for me, thank you! On the other hand, at present, the only way to apply this change to anything other than rolling is to use a patched fork to build ament_cmake from source. However, since I want more people to use this patch and put an end to the include path pollution, I came up with an alternative solution. I propose to add an argument to the |
I think that's a great idea! |
|
Thank you for your advice. |
This pull-request backports a bug fix for
ament_auto_packageto humble branch.#540 changes the header install target, but it shouldn't be destructive since it updating dependencies properly.