Skip to content

[backport][galactic] Make ament_python_install_package() install console_scripts (#328)#364

Merged
hidmic merged 1 commit intoament:galacticfrom
wep21:galactic-backport-328
Dec 7, 2021
Merged

[backport][galactic] Make ament_python_install_package() install console_scripts (#328)#364
hidmic merged 1 commit intoament:galacticfrom
wep21:galactic-backport-328

Conversation

@wep21
Copy link
Copy Markdown
Contributor

@wep21 wep21 commented Nov 26, 2021

Backport #328 to galactic.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@wep21 wep21 changed the title Make ament_python_install_package() install console_scripts (#328) [backport] [galactic] Make ament_python_install_package() install console_scripts (#328) Nov 26, 2021
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Nov 26, 2021

@hidmic @cottsay Could you review this?

@wep21 wep21 changed the title [backport] [galactic] Make ament_python_install_package() install console_scripts (#328) [backport][galactic] Make ament_python_install_package() install console_scripts (#328) Nov 26, 2021
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks innocuous to me. @cottsay?

Galactic CI above ament_cmake_python:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit 573972a into ament:galactic Dec 7, 2021
@wep21 wep21 deleted the galactic-backport-328 branch December 7, 2021 19:20
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Dec 8, 2021

Could someone also create a PR to rosdistro? @hidmic @cottsay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants