Add 'runner' option to ament_add_gmock / nose#177
Merged
dirk-thomas merged 2 commits intoament:masterfrom Jun 11, 2019
Merged
Conversation
added 2 commits
June 10, 2019 14:10
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
This was referenced Jun 10, 2019
Contributor
|
Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to #174
I would like to be able execute gmock tests with a different test runner too. (This is what rosbag2 uses, which are the tests I'm trying to isolate)
I didn't realize 'add_gmock' was another type of test that could be added in ros2. I thought ament_add_pytest_test and ament_add_gtest took care of everything.
While I'm at it, I also took care of ament_add_nose_test too.