Skip to content

inject classname for gtest result files#117

Merged
dirk-thomas merged 1 commit intomasterfrom
gtest_classname
Nov 16, 2017
Merged

inject classname for gtest result files#117
dirk-thomas merged 1 commit intomasterfrom
gtest_classname

Conversation

@dirk-thomas
Copy link
Copy Markdown
Contributor

@dirk-thomas dirk-thomas commented Nov 15, 2017 •
edited
Loading

Sadly gtest doesn't offer a way to customize the classname attribute which is used by Jenkins xunit to create the hierarchy. Therefore I chose to modify the generated gtest result files.

Before the gtest results were under the (root) entry with no indication to the package: http://ci.ros2.org/job/ci_linux/3531/testReport/(root)/

After they are under an entry names after the package: http://ci.ros2.org/job/ci_linux/3540/testReport/ament_index_cpp/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 15, 2017
@dirk-thomas dirk-thomas self-assigned this Nov 15, 2017
@dirk-thomas dirk-thomas mentioned this pull request Nov 15, 2017
Merged
mikaelarguedas
mikaelarguedas approved these changes Nov 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change lgtm, looking forward for green CI with the test results with the new hierarchy

@mikaelarguedas
Copy link
Copy Markdown
Contributor

mikaelarguedas commented Nov 15, 2017

Looks good,

Some gtests seem to not be impacted:
http://ci.ros2.org/job/ci_linux/3541/testReport/(root)/projectroot/class_loader_fviz_test/
http://ci.ros2.org/job/ci_linux/ws/ws/build/class_loader/test_results/class_loader/class_loader_fviz_test.gtest.xml

@dirk-thomas
Copy link
Copy Markdown
Contributor Author

dirk-thomas commented Nov 15, 2017

All results reported under (root)/projectroot are coming from CTest directly. That means the relevant xUnit result files are in the package build folder under Testing/<timestamp>. We currently don't touch these result files at all.

gtest itself will also generate a result file, the one you referenced: build/class_loader/test_results/class_loader/class_loader_fviz_test.gtest.xml. The content of that is:

<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="1" failures="0" disabled="0" errors="0" timestamp="2017-11-15T22:13:34" time="0.001" name="AllTests">
  <testsuite name="FvizTest" tests="1" failures="0" disabled="0" errors="0" time="0.001">
    <testcase name="basic_test" status="run" time="0.001" classname="class_loader.FvizTest" />
  </testsuite>
</testsuites>

The classname attribute has been prepended with the package name class_loader.. Therefore you will find a class_loader item in the main test result page (http://ci.ros2.org/job/ci_linux/3541/testReport/). Without this patch the test was reported under (root)/FvizTest (e.g. http://ci.ros2.org/view/nightly/job/nightly_linux_debug/647/testReport/(root)/FvizTest/).

@mikaelarguedas
Copy link
Copy Markdown
Contributor

mikaelarguedas commented Nov 15, 2017

xUnit result files are in the package build folder under Testing/. We currently don't touch these result files at all.

Ok that's the part I missed. Thanks for clarifying

Therefore you will find a class_loader item in the main test result page (http://ci.ros2.org/job/ci_linux/3541/testReport/).

Yeah as it happens quite often recently I was unable to open the class_loader folder on the main page so I looked into the one in (root)/projectroot. Are you able to display http://ci.ros2.org/job/ci_linux/3541/testReport/class_loader/ ?

@dirk-thomas
Copy link
Copy Markdown
Contributor Author

dirk-thomas commented Nov 16, 2017

I get the feeling that the problem is related to follow up builds. I created a separate job and there it works fine again: http://ci.ros2.org/view/All/job/dirk_ci_linux/1/testReport/class_loader/

Maybe Jenkins has a problem to open the test results from previous builds if newer builds have been triggered or are ongoing?

@dirk-thomas dirk-thomas merged commit a8648e8 into master Nov 16, 2017
@dirk-thomas dirk-thomas deleted the gtest_classname branch November 16, 2017 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dirk-thomas dirk-thomas

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dirk-thomas @mikaelarguedas