Skip to content

Update maintainer list in package.xml files#503

Merged
clalancette merged 2 commits intorollingfrom
mjeronimo/update-package-files
Feb 8, 2024
Merged

Update maintainer list in package.xml files#503
clalancette merged 2 commits intorollingfrom
mjeronimo/update-package-files

Conversation

@mjeronimo
Copy link
Copy Markdown

I'm no longer a maintainer and don't need to be credited as an author.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Feb 7, 2024

I think this should be changed here, if that tool is still used: https://github.com/audrow/update-ros2-repos/tree/main/apps/update-maintainers/data. For example, see #411.

Otherwise, the CODEOWNERS file should also be updated.

@clalancette
Copy link
Copy Markdown
Contributor

I think this should be changed here, if that tool is still used: https://github.com/audrow/update-ros2-repos/tree/main/apps/update-maintainers/data. For example, see #411.

For now, we aren't using that tool. So I'd say that this is OK for now. But I agree that it would be a good idea to remove the entry from CODEOWNERS as well.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette merged commit 6b310f5 into rolling Feb 8, 2024
@delete-merged-branch delete-merged-branch bot deleted the mjeronimo/update-package-files branch February 8, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants