Skip to content

[backport] [galactic] Make ament_cmake_python symlink for symlink installs only (#357)#359

Merged
hidmic merged 1 commit intoament:galacticfrom
Yaskawa-Global:backport_357_galactic
Oct 20, 2021
Merged

[backport] [galactic] Make ament_cmake_python symlink for symlink installs only (#357)#359
hidmic merged 1 commit intoament:galacticfrom
Yaskawa-Global:backport_357_galactic

Conversation

@gavanderhoorn
Copy link
Copy Markdown

@gavanderhoorn gavanderhoorn commented Oct 13, 2021

Backport #357.

@hidmic @gavanderhoorn
Make ament_cmake_python symlink for symlink installs only (ament#357)
74435f8 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 13, 2021

If a FF of galactic to master is preferred (#357 (comment)) someone else will have to do that :)

@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 13, 2021

@hidmic

@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 14, 2021

Friendly ping?

hidmic
hidmic approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I am. LGTM pending green Galactic CI and @cottsay's blessing.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 15, 2021 •
edited
Loading

Heh, seems they all failed:

-- Found Python3: /home/jenkins-agent/workspace/ci_linux/venv/bin/python3.8 (found version "3.8.10") found components: Interpreter 
CMake Error at /home/jenkins-agent/workspace/ci_linux/ws/install/rosidl_adapter/share/rosidl_adapter/cmake/rosidl_adapt_interfaces.cmake:42 (get_executable_path):
  Unknown CMake command "get_executable_path".
Call Stack (most recent call first):
  /home/jenkins-agent/workspace/ci_linux/ws/install/rosidl_cmake/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:130 (rosidl_adapt_interfaces)
  CMakeLists.txt:46 (rosidl_generate_interfaces)

@hidmic
Copy link
Copy Markdown

hidmic commented Oct 18, 2021

@gavanderhoorn this PR should be targeting the galactic branch.

@gavanderhoorn gavanderhoorn changed the base branch from master to galactic October 18, 2021 18:11
@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 18, 2021

Changed.

@hidmic
Copy link
Copy Markdown

hidmic commented Oct 19, 2021

Let's try again:

  • Linux Build Status

@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 19, 2021

Seems to be failing again?

@hidmic
Copy link
Copy Markdown

hidmic commented Oct 19, 2021

Argh, I've been trying to use a rolling .repos file 🤦‍♂️... My bad.

@hidmic
Copy link
Copy Markdown

hidmic commented Oct 19, 2021 •
edited
Loading

Galactic CI (for real now 🤦‍♂️):

  • Linux Build Status
  • Linux-aarch64 Build Status (unrelated test failures)
  • macOS Build Status
  • Windows Build Status

cottsay
cottsay approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport seems like a good idea, thanks. 👍 (pending CI)

@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 20, 2021

Finally. (Mostly) green badges 🎉

@hidmic
Copy link
Copy Markdown

hidmic commented Oct 20, 2021

Alright, going in. Thanks for the patience @gavanderhoorn.

@hidmic hidmic merged commit a803f85 into ament:galactic Oct 20, 2021
@gavanderhoorn gavanderhoorn deleted the backport_357_galactic branch October 20, 2021 13:56
@gavanderhoorn
Copy link
Copy Markdown
Author

gavanderhoorn commented Oct 20, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cottsay cottsay cottsay approved these changes

@hidmic hidmic hidmic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gavanderhoorn @hidmic @cottsay