Make ament_python_install_package() match setuptools' egg names.#338
Merged
Make ament_python_install_package() match setuptools' egg names.#338
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
May 27, 2021
Contributor
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM with green CI (it would be good to test a package actually using the macro)
Author
|
Full CI, just in case:
|
Author
|
Alright, full CI's happy. Moving on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small enhancement. This avoids discrepancies between flat eggs installed by
ament_python_install_package()and flat eggs installed bysetuptools. Seesetuptoolsdocumentation for further reference on the naming scheme.