Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
commented
Oct 7, 2020
| @@ -5,6 +5,7 @@ | |||
| <version>1.0.1</version> | |||
| <description>The ability to add Google Benchmark tests in the ament buildsystem in CMake.</description> | |||
| <maintainer email="scott@openrobotics.org">Scott K Logan</maintainer> | |||
Author
There was a problem hiding this comment.
@cottsay will you be maintaining this package? I haven't changed this yet, I wasn't sure.
Contributor
There was a problem hiding this comment.
I don't think it should be treated any different from the other ament_cmake packages, so it should probably be changed to you and @dirk-thomas.
dirk-thomas
approved these changes
Oct 7, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
kenji-miyake
pushed a commit
to kenji-miyake/ament_cmake
that referenced
this pull request
Oct 20, 2021
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precisely what the title says, so we can share the load :)