Make node-webcrypto-ossl an optional dependency.#689
Conversation
`node-webcrypto-ossl` is a native Node package, and will only be used in a very specific instance (using SEA from Node). In my case, and I suppose in many others', SEA in Node will never be used. I'd like to have that dependency made optional, since a failure to require it [is already handled](https://github.com/amark/gun/blob/535d6569fcff380faefe8ffafbeb658a1635b74f/sea.js#L183). Furthermore on Windows it requires the entire native build toolchain to be installed, which is not ideal for such a small feature.
|
@71 I totally agree, but the community out-voted me on this :( Although, I see it is this ?new? thing called Qs:
WELCOME TO THE COMMUNITY BTW!!!! :) |
|
@amark Hey, thanks for the quick reply! Well, to cite the npm docs:
Therefore, according to these docs:
Additionally |
|
Okay, then I feel like this is safe enough that I should just do it :D :D :D thank you!!! It would be nice if there was something like Will be pulling anyways. How'd you find out about GUN? What are you planning on building? |
|
I thought about having two packages; one "core" package with only Gun, and another one with Gun + optional packages. Otherwise I haven't worked much with I don't exactly remember how I found out about Gun, sorry (probably just a Google search with the right keywords: |
|
@amark Did you publish this yet? It would save us a lot of time installing dependencies (not using it either) |
|
@71 yaaaay that you are liking GUN better so far :) thank you for reporting & contributing to this issue rather than just walking away, very much appreciate that. @finwo you should have spoken up and defended me then when the community did a PR to switch these deps from devDeps to regular deps! :P :P I didn't want to do it but everybody else in the issue was shaming me for not having them hard-coded. (not that I fall to peer-pressure, but on things like this, I certainly want to be mindful of community). This was opened just a little bit after @71 & @finwo you have critical needs as an excuse for me to publish sooner :P , sounded like @finwo you hinted on chat you guys actually running this in production !? I'd love to hear more about the use case :D :D :D ! |
|
@amark I wasn't monitoring the discussions back then. The release-cycle is up to you. Both larger and micro-updates have pros and cons. I would even separate SEA into a separate package, to keep logical layers separated. The platform I'm using it for is planned to go into production at the end of this month, but I won't pollute this PR with further details. |
node-webcrypto-osslis a native Node package, and will only be used in a very specific instance (using SEA from Node).In my case, and I suppose in many others', SEA in Node will never be used.
I'd like to have that dependency made optional, since a failure to require it is already handled. Furthermore on Windows it requires the entire native build toolchain to be installed, which is not ideal for such a small feature.