windows-set: avoid frame race condition#98
Conversation
|
|
|
Anything else need a look here? |
Looking at this code again, now that you've apparently fixed an outstanding bug with the binding of Also, forgive the nitpicking, but I'd suggest simplifying the |
I actually don't know what function that copying served vs. the let-binding already happening in I also note that
Sure, done. In fact I went all the way and passed the copied/bufferized state as an argument too. |
window-set: bind frame in top let for race-condition fix windows-set: bind window-persistent-parameters in timer callback windows-set: pass selected frame as argument, don't copy params Remove reference to non-existent set-window-persistent-parameters window-set: further simplify immediate timer call
a4e4bb5 to
8d54734
Compare
|
Thanks, merged. |
In discussion #78 I suggested a loop over activity names, calling
activities-resume. This doesn't work reliably, because of theHACKinactivities--windows-set, which uses an "immediate" timer. When rapidly resuming activities in a loop, by the time the timer is called, the frame will have changed, and the activities' contents are bungled.