annotate: skip file-truename for remote files#133
Merged
alphapapa merged 2 commits intoalphapapa:masterfrom Feb 23, 2025
Merged
annotate: skip file-truename for remote files#133alphapapa merged 2 commits intoalphapapa:masterfrom
alphapapa merged 2 commits intoalphapapa:masterfrom
Conversation
The test for a "dirty" activity used by the annotation function and when updating the timestamp within the activity is based on whether the "set of buffers and files" has changed. We use `file-truename` to look for "real" file changes but that can hang on remote files. To alleviate, we only check the `file-truename` on non-remote files.
Contributor
Author
|
This is really kind of a tramp issue, but if you save an activity with a remote file included that is accessible only in some locations (or some networks), |
Owner
|
Ah, this sounds like it might be the solution for #130! |
Contributor
Author
|
Oh interesting, hadn't seen that one. Tramp sets some pretty deep hooks... |
Owner
|
Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test for a "dirty" activity used by the annotation function and
when updating the timestamp within the activity is based on whether
the "set of buffers and files" has changed. We use
file-truenametolook for "real" file changes but that can hang on remote files. To
alleviate, we only check the
file-truenameon non-remote files.