Fix Jasmine specs in govuk-docker on Apple silicon#2723
Merged
floehopper merged 1 commit intomainfrom Feb 16, 2024
Merged
Conversation
richardTowers
approved these changes
Feb 16, 2024
We've been seeing the following error running the Jasmine specs in a
govuk-docker container running on Apple silicon:
SessionNotCreatedError: session not created:
Chrome failed to start: exited normally.
For a full diagnosis of the problem see this govuk-docker PR [1] which
was a first attempt at fixing the problem.
Note that the problem was also triggering a warning like the following
even on non-Apple silicon:
The chromedriver version (120.0.6099.199) detected in PATH at
/usr/bin/chromedriver might not be compatible with the detected chrome
version (121.0.6167.85); currently, chromedriver 121.0.6167.85 is
recommended for chrome 121.*, so it is advised to delete the driver in
PATH and retry
This PR forces yarn to install v4.17.0 of the `selenium-webdriver` node
package which includes a fix [2] to the `selenium-manager` CLI app
included in the `selenium-webdriver` node package so that it now
correctly finds the chromium binary. This fixes both the error on Apple
silicon and the warning on all devices.
[1]: alphagov/govuk-docker#724
[2]: SeleniumHQ/selenium#12890
7fc39a5 to
3e35ced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing the following error running the Jasmine specs in a govuk-docker container running on Apple silicon:
For a full diagnosis of the problem see this govuk-docker PR which was a first attempt at fixing the problem.
Note that the problem was also triggering a warning like the following even on non-Apple silicon:
This PR forces yarn to install v4.17.0 of the
selenium-webdrivernode package which includes a fix to theselenium-managerCLI app included in theselenium-webdrivernode package so that it now correctly finds the chromium binary. This fixes both the error on Apple silicon and the warning on all devices.Note that I've opened a PR on
jasmine-browser-runnerto bump its version ofselenium-webdriver. Once that PR is merged and released, we should be able to remove theresolutionentry forselenium-webdriver.