fix(ReduceStore): When setState invalid object, throw assertion error

azu · azu · commit e391f632834d · 2017-01-03T01:38:44.000+09:00
diff --git a/src/ReduceStore.js b/src/ReduceStore.js
@@ -1,5 +1,6 @@
 // LICENSE : MIT
 "use strict";
+const assert = require("assert");
 import {Store} from "almin";
 export default class ReduceStore extends Store {
     constructor() {
@@ -18,6 +19,12 @@ export default class ReduceStore extends Store {
      * @param {ReduceState} newState
      */
     setState(newState) {
+        if (process.env.NODE_ENV === 'development') {
+            assert(newState instanceof this.state.constructor, `newState should be instanceof exist this.state.constructor.
+newState: ${newState}
+this.state.constructor: ${this.state.constructor}
+`);
+        }
         if (this.state.equals(newState)) {
             return;
         }
diff --git a/test/ReduceStore-test.js b/test/ReduceStore-test.js
@@ -32,4 +32,22 @@ describe("ReduceStore", () => {
             useCase.execute();
         });
     });
+    context("when wrong setState", () => {
+        it("should throw assertionError", () => {
+            class TestStore extends ReduceStore {
+                constructor() {
+                    super();
+                    this.state = new AlwaysNewState();
+                }
+            }
+            const store = new TestStore();
+            try {
+                const invalidStateShape = {};
+                store.setState(invalidStateShape);
+                throw new Error("SHOULD NOT THROWN ERROR");
+            } catch (error) {
+                assert(error.name === "AssertionError");
+            }
+        });
+    });
 });
