Skip to content

fix(almin): export UseCaseExecutor from index#243

Merged
azu merged 1 commit intomasterfrom
UseCaseExecutor-exported
Jul 16, 2017
Merged

fix(almin): export UseCaseExecutor from index#243
azu merged 1 commit intomasterfrom
UseCaseExecutor-exported

Conversation

@azu
Copy link
Copy Markdown
Member

@azu azu commented Jul 16, 2017 •
edited
Loading

BREAKING CHANGE: remove on* handler from UseCaseExecutor.
Use UseCaseExecutor#onDispatch instead of it.

We don't know this handler use-case.

If you want to this, please file new issue.

  • export UseCaseExecutor from index

This is useful for wrapper function of context.useCase

/**
 * Extends React.Component for Container.
 * It has executor feature for almin UseCase.
 */
export class BaseContainer<T, P> extends React.Component<T, P> {
    useCase<T extends UseCase>(useCase: T): UseCaseExecutor<T> {
        return appLocator.context.useCase(useCase);
    }
}

fix #206

@azu
fix(almin): export UseCaseExecutor from index
b916454 
BREAKING CHANGE: remove on* handler from UseCaseExecutor.
Use UseCaseExecutor#onDispatch instead of it.

We don't know this handler use-case.
azu
azu commented Jul 16, 2017
View reviewed changes
packages/almin/src/UseCaseExecutor.ts
* called the {@link handler} with useCase when the useCase will do.
* @param handler
*/
onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void {
Copy link
Copy Markdown
Member Author

@azu azu Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove life-cycle on UseCaseExecutor

@azu azu merged commit 1b3d515 into master Jul 16, 2017
@azu azu deleted the UseCaseExecutor-exported branch July 16, 2017 02:49
This was referenced Jul 16, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Almin: lifecyle method in UseCaseExectutor will be deprecated.

1 participant

@azu