Conversation
Add StoreChangedPayload that is created by Store#onChangeDetails.
Currently, almin has `StoreGroup#onChange((stores) => {}`, but this callback shape is difference with other payload.
Now, almin introduce the same format payload for StoreGroup.
azu
commented
Jul 15, 2017
packages/almin/src/Context.ts
Outdated
| const payload = new StoreChangedPayload(store); | ||
| const meta = new DispatcherPayloadMetaImpl({ | ||
| // this dispatch payload generated by this UseCase | ||
| useCase: undefined, |
`Context.on*` is deprecated and prepare migration scripts almin/migration-tools#1 This deprecated handler will be removed next release
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
context.on*tocontext.events.on*withoutcontext.onChangecontext.on*is deprecated. These will be removed in the furture.Context.onChangeis still onContextprototype.to
Add
StoreChangedPayloadthat is created byStore#onChange.Currently, almin has
StoreGroup#onChange((stores) => {}, but this callback shape is difference with other payload.Now, almin introduce the same format payload for StoreGroup.
The implementation match following figure.
All events pass through LifeCycleEventHub.