Skip to content

Conversation

@todti
Copy link
Contributor

@todti todti commented Apr 9, 2025

Context

Added convert ansi syntax for error message and trace

Checklist

@todti todti requested a review from epszaw April 9, 2025 08:49
@todti todti added the type:improvement Change that improves some user experience but can't be considered as a new feature label Apr 9, 2025
@noomorph
Copy link
Contributor

noomorph commented Apr 9, 2025

Is this really a good idea? Category matching regular expressions won't work very well with such status messages, so maybe it's better to clean up the jsons (strip ansi) from Allure framework reporter before generating the HTML report.

@baev
Copy link
Member

baev commented Apr 9, 2025

@noomorph, good catch. We can match categories against cleared messages & traces

@todti todti force-pushed the ansi-implementation branch from c2aecfb to 79e1a1a Compare April 9, 2025 13:31
@baev
Copy link
Member

baev commented Apr 22, 2025

@noomorph see #2959

@baev
Copy link
Member

baev commented Apr 22, 2025

@todti good job!

@baev baev merged commit 08102e3 into main Apr 22, 2025
17 checks passed
@baev baev deleted the ansi-implementation branch April 22, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:ui type:improvement Change that improves some user experience but can't be considered as a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants