Conversation
pratushnyi
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This fixes #296.
When
allureDownloadUrlis configured, the plugin uses its own direct download path instead of Maven artifact resolution. That meant standard Maven/Wagon SSL flags like-Dmaven.wagon.http.ssl.insecure=truehad no effect, even though the same flags worked for normal Maven downloads. For teams hosting the Allure CLI in internal Artifactory or other HTTPS endpoints with private certificates,allure:installcould fail with SSL validation errors.This change makes the direct download path respect the Maven session properties for
maven.wagon.http.ssl.insecure,maven.wagon.http.ssl.allowall, andmaven.wagon.http.ssl.ignore.validity.dates. In practice, that makes customallureDownloadUrlbehavior much closer to the rest of Maven, which is what users expect. I also added tests around the relaxed SSL handling so this behavior is covered going forward.Example:
mvn -Dmaven.wagon.http.ssl.insecure=true \ -Dmaven.wagon.http.ssl.allowall=true \ allure:installWith this patch, those flags now apply to direct CLI downloads as well.
Checklist