-
Notifications
You must be signed in to change notification settings - Fork 21
Update spring version #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 4.11.0 to 5.17.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.11.0...v5.17.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-version: 5.17.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `spring.version` from 4.2.5.RELEASE to 6.2.5. Updates `org.springframework:spring-beans` from 4.2.5.RELEASE to 6.2.5 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v4.2.5.RELEASE...v6.2.5) Updates `org.springframework:spring-context` from 4.2.5.RELEASE to 6.2.5 - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v4.2.5.RELEASE...v6.2.5) --- updated-dependencies: - dependency-name: org.springframework:spring-beans dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.springframework:spring-context dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.atlassian.plugins:atlassian-plugins-osgi-testrunner](https://bitbucket.org/atlassian/atlassian-plugins-osgi-testrunner-parent) from 2.0.9 to 2.0.10. - [Changelog](https://bitbucket.org/atlassian/atlassian-plugins-osgi-testrunner-parent/src/master/CHANGELOG.md) - [Commits](https://bitbucket.org/atlassian/atlassian-plugins-osgi-testrunner-parent/branches/compare/atlassian-plugins-osgi-testrunner-parent-2.0.10..atlassian-plugins-osgi-testrunner-parent-2.0.9) --- updated-dependencies: - dependency-name: com.atlassian.plugins:atlassian-plugins-osgi-testrunner dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#370) Bumps [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.2.0 to 2.44.4. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@v2.2.0...maven/2.44.4) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-version: 2.44.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…355) Bumps [org.apache.maven.plugins:maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.21.2 to 3.26.0. - [Release notes](https://github.com/apache/maven-pmd-plugin/releases) - [Commits](apache/maven-pmd-plugin@maven-pmd-plugin-3.21.2...maven-pmd-plugin-3.26.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-pmd-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency versions—including Spring from 4.2.5.RELEASE to 6.2.5—and aligns various plugin and PMD versions. It also includes minor code refactoring such as adding serialVersionUID constants and replacing HashMap initializations with Map.of.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/io/qameta/allure/bamboo/info/allurewidgets/summary/AbstractSummary.java | Added serialVersionUID for serialization consistency. |
| src/main/java/io/qameta/allure/bamboo/info/AddTestRunInfo.java | Replaced mutable HashMap with an immutable Map.of instance for report data. |
| src/main/java/io/qameta/allure/bamboo/info/AddExecutorInfo.java | Replaced mutable HashMap with an immutable Map.of instance for executor info. |
| src/main/java/io/qameta/allure/bamboo/info/AbstractAddInfo.java | Added serialVersionUID for serialization consistency. |
| src/main/java/io/qameta/allure/bamboo/ViewAllureReport.java | Added serialVersionUID to the view class. |
| src/main/java/io/qameta/allure/bamboo/ConfigureAllureReportAction.java | Added serialVersionUID to the configuration action class. |
| src/main/java/io/qameta/allure/bamboo/AllureReportServlet.java | Added serialVersionUID and a PMD warning suppression comment. |
| src/main/java/io/qameta/allure/bamboo/AllurePluginException.java | Added serialVersionUID for exception serialization. |
| src/main/java/io/qameta/allure/bamboo/AllureExecutable.java | Added suppression for PMD LooseCoupling. |
| src/main/java/io/qameta/allure/bamboo/AllureBuildConfigurator.java | Added suppression for a PMD warning regarding constructor calls. |
| src/main/java/io/qameta/allure/bamboo/AllureBuildConfig.java | Updated the default logo URL and streamlined constant usage. |
| src/main/java/io/qameta/allure/bamboo/AllureBuildCompleteAction.java | Added additional PMD warning suppression. |
| src/main/java/io/qameta/allure/bamboo/AllureArtifactsManager.java | Extended PMD suppression to include CouplingBetweenObjects. |
| pom.xml | Upgraded dependency and plugin versions along with a Spring version change. |
| .mvn/wrapper/maven-wrapper.properties | Updated Maven wrapper version. |
| .mvn/quality-configs/pmd/pmd.xml | Updated PMD exclusions and rule configurations. |
Comments suppressed due to low confidence (2)
src/main/java/io/qameta/allure/bamboo/info/AddTestRunInfo.java:45
- Switching from a mutable HashMap to an immutable Map via Map.of might affect downstream code expecting a modifiable map. Please verify that any consumers of getData() do not attempt to modify the returned map.
return Map.of(
src/main/java/io/qameta/allure/bamboo/info/AddExecutorInfo.java:53
- Changing to Map.of creates an immutable map, which could be problematic if any code later attempts to modify the map. Please ensure that the data structure immutability is acceptable for all its usages.
return Map.of(
No description provided.