Skip to content

Conversation

@ARUS2023
Copy link
Contributor

@ARUS2023 ARUS2023 commented Oct 6, 2023

In our analysis of the project, we observed that the stubbing which stubbed downloadAndExtractAllureTo is created in AllureExecutableProviderTest.setUp, but is never executed by 2 tests: AllureExecutableProviderTest.itShouldProvideExecutableForUnix and AllureExecutableProviderTest.itShouldProvideExecutableForWindows.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

@vbragin vbragin merged commit 0d984e0 into allure-framework:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants