fix(devcontainer): add conditional zsh support and fix broken devcontainer config #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer config - Added DEVCONTAINER arg/env in Dockerfile to enable conditional zsh install - Updated devcontainer.json to set build target to "dev" and pass DEVCONTAINER=1 - Removed "remoteUser": "appuser" to prevent container crash - Replaced old GitHub CLI feature key with updated version - Added VS Code extension recommendations for Python, Prisma, Ruff, etc. - Removed deprecated pre-commit feature
Contributor
Reviewer's GuideThis PR fixes and enhances the devcontainer setup by adding conditional zsh support in the Dockerfile and updating the devcontainer.json configuration to prevent crashes, update tooling, and refresh recommended extensions. Flow Diagram: Conditional Zsh Installation Logic in Dockerfilegraph TD
Start[Start of Dockerfile 'dev' stage script with DEVCONTAINER arg] --> CheckArg{Check value of $DEVCONTAINER};
CheckArg -- "$DEVCONTAINER = 1" --> InstallZsh["RUN apt-get update && \napt-get install -y zsh && \nchsh -s /usr/bin/zsh && \napt-get clean && rm -rf /var/lib/apt/lists/*"];
CheckArg -- "$DEVCONTAINER != 1" --> SkipZsh["echo 'Not building for devcontainer, skipping devcontainer dependencies installation'"];
InstallZsh --> NextStep[Continue with subsequent Dockerfile commands];
SkipZsh --> NextStep;
NextStep --> End[End of script / Docker image layer built];
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @alik-6 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
trailing comma in devcontainer.json...
Contributor
|
LGTM, tested and works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
[ x ] I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
N/A
Screenshots (if applicable)
N/A
Additional Information
N/A