Skip to content

Conversation

@kzndotsh
Copy link
Contributor

No description provided.

kzndotsh and others added 30 commits January 8, 2024 18:05
[Fix] Merge main into Alpha for ruff fixes
[Fix] Error handler and ping command
Pyright type checking has been set to basic for now.

The pre-commit hooks for `ruff-pre-commit` and `pyright-python` have been updated to their latest versions for code quality improvements. The `pre-commit-config` and `pyproject.toml` files were modified to reflect these changes.

Also, the error handler has been completely rewritten in a more flexible and scalable manner, addressing various error scenarios in a cleaner and clearer way. Individual error handling methods for common cases are now in place, making it easier to extend with more exception types in the future.

Removed some unused references to the old error handler in the main application file, simplifying the logic there. The `pyright` type checking configuration in `pyproject.toml` was also adjusted for less strict checking, better suited to our current project requirements.

Lastly, the lockfile `poetry.lock` was updated and unnecessarily tagged "dev" packages were removed.

In the wake of these changes, be mindful that the behaviour of error prompts to the user and of type checks may slightly differ.

Additional notes include punctuation and formatting adjustments to improve readability throughout the files changed.
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kzndotsh kzndotsh merged commit 11116bc into main Mar 24, 2024
@kzndotsh kzndotsh deleted the Alpha branch March 24, 2024 20:32
@sentry
Copy link

sentry bot commented Mar 25, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFound: 404 Not Found (error code: 10008): Unknown Message events.on_command_completion in on_command_comp... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants