Skip to content

feat(consensus): introduce block traits#2057

Merged
mattsse merged 7 commits intomainfrom
yash/blockT
Feb 15, 2025
Merged

feat(consensus): introduce block traits#2057
mattsse merged 7 commits intomainfrom
yash/blockT

Conversation

@yash-atreya
Copy link
Copy Markdown
Contributor

Motivation

Closes #2033
Unblocks #2032

Solution

Introduce BlockBodyT and BlockT

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya marked this pull request as ready for review February 14, 2025 06:02
Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this very minimal for now

@yash-atreya yash-atreya requested a review from mattsse February 14, 2025 10:48
@yash-atreya yash-atreya enabled auto-merge (squash) February 14, 2025 10:48
Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it even more simple for now, I want to avoid locking in something that we might change later which would be breaking

trait Block {fn withdrawals}

@yash-atreya yash-atreya requested a review from mattsse February 14, 2025 14:44
@yash-atreya yash-atreya requested a review from mattsse February 14, 2025 15:03
@DaniPopes DaniPopes disabled auto-merge February 15, 2025 13:09
@mattsse mattsse merged commit 249b4f4 into main Feb 15, 2025
@mattsse mattsse deleted the yash/blockT branch February 15, 2025 16:58
@yash-atreya yash-atreya self-assigned this Feb 24, 2025
@jenpaff jenpaff moved this from Done to Completed in Alloy Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

[Feature] Block and Body trait

3 participants