Skip to content

chore: move txtype-specific builders to network-primitives#1602

Merged
klkvr merged 4 commits intomainfrom
klkvr/move-builders-to-network-primitives
Nov 1, 2024
Merged

chore: move txtype-specific builders to network-primitives#1602
klkvr merged 4 commits intomainfrom
klkvr/move-builders-to-network-primitives

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented Nov 1, 2024

Motivation

ref alloy-rs/op-alloy#215

We need to import those traits from op-alloy-rpc-types, however, right now this breaks no-std support due to dependency on alloy-network.

Solution

Move those traits to alloy-network-primitives which is no-std compatible

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@klkvr klkvr enabled auto-merge (squash) November 1, 2024 16:21
@klkvr klkvr merged commit ab78ea0 into main Nov 1, 2024
@klkvr klkvr deleted the klkvr/move-builders-to-network-primitives branch November 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants