Skip to content

[Bug] Numeric type audit in transaction and block structs and provider methods, remove gratuitous U256s #433

@prestwich

Description

@prestwich

Component

consensus, eips, genesis

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Noticed discrepancy while implementing From<TypedTransaction> for TransactionRequest

all types should have the following (with options as necessary)

applies to
consensus
rpc
providers return values
etc

block_number: u64

transaction_index: u64

gas_price: u128

// make sure names are consistent here too. these are the same field
gas: u128
gas_limit: u128

max_fee_per_gas: u128

max_priority_fee_per_gas: u128

max_fee_per_blob_gas: u128

value: U256

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions