Apply 'fm_presave_alter_values' to Fieldmanager_Options#568
Merged
Conversation
Contributor
|
While it technically is backwards-incompatible, that is a small price to pay. Proceed! 👍 |
As the tests now need to cover multiple fields.
Member
Author
|
As was noted in #394, the issue this PR addresses also applies to autocomplete fields. I've expanded the scope of this PR to include autocompletes, although those changes could be moved into a separate PR if you'd like. |
Contributor
|
I'm in favor of autocomplete being a part of this PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at #523 and a partial refresh of #394. However, is it a backwards-incompatibility to start applying this filter now?