@jjrdevspace01 Glad to hear it, thanks for testing! We'll ship 1.4.1 today.

i would agree with your note that display_if does have some performance issues at scale

For what it's worth, the issue isn't tied to display_if. You encountered it in a field that hinges on display_if because you're using that feature to conditionally render one of many modules, a great use of Fieldmanager in my opinion, and something we at Alley did a lot pre-Gutenberg.

The problem is with how field attributes get modified when adding or sorting groups, and the issue gets very bad if those groups have many fields/subgroups within them. Where display_if factors in is, if you have 20 modules, each with groups of fields, even though only one is rendered at a time, the other 19 are still present in the DOM and are still modified when rendering or sorting. Sorting is actually the worst part; if you add several modules and then drag the last to the first, your browser will probably hang for a few seconds even with the "performant" code.

As an aside, given how many fields you're generating, you may at some point run into a limitation on your web server where some fields are truncated from the request. This is a webserver setting and if I recall correctly, the limit is usually somewhere around 6,000 fields. A lot, but these can add up! If you do ever encounter that, here's a gist that can help you out, it removes all the hidden fields that the server request doesn't need. You'll have to modify it to match your field names, but it should save you a big headache!

Performance regression in fm_renumber in fieldmanager 1.4.0 #827

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions