Skip to content

check vars first#35

Merged
timatron merged 2 commits intomasterfrom
bug-index-args
Sep 20, 2016
Merged

check vars first#35
timatron merged 2 commits intomasterfrom
bug-index-args

Conversation

@timatron
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@mboynes mboynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional cleanup can be done, then 👍

bin/wp-cli.php Outdated
}

if ( $assoc_args['put-mapping'] ) {
if ( ! empty( $assoc_args['put-mapping'] ) && $assoc_args['put-mapping'] ) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can just check ! empty(), you can erase the && ...

@timatron
Copy link
Copy Markdown
Contributor Author

Want me to do the other vars?

Sent from my iPhone

On Sep 19, 2016, at 19:03, Matthew Boynes notifications@github.com wrote:

@mboynes approved this pull request.

Some additional cleanup can be done, then 👍

In bin/wp-cli.php:

        $this->flush();
  }
  • if ( $assoc_args['put-mapping'] ) {
    
  • if ( ! empty( $assoc_args['put-mapping'] ) && $assoc_args['put-mapping'] ) {
    
    These can just check ! empty(), you can erase the && ...


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@timatron timatron merged commit 77b91b2 into master Sep 20, 2016
@renatonascalves renatonascalves deleted the bug-index-args branch February 22, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants